Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in fromMonth/toMonth and showMonth method #95

Closed
jkillian opened this issue Nov 19, 2015 · 4 comments
Closed

Bug in fromMonth/toMonth and showMonth method #95

jkillian opened this issue Nov 19, 2015 · 4 comments

Comments

@jkillian
Copy link
Contributor

Say toMonth is set to December 2015 and someone tried to call showMonth(new Date(2015,11)) in order to display December 2015.

allowMonth incorrectly returns false as toMonth and d are the same month. It should return true. I believe this should be a simple fix by changing Helpers.getMonthsDiff(toMonth, d) >= 0 to Helpers.getMonthsDiff(toMonth, d) > 0 (and doing the same for fromMonth).
@jkillian jkillian mentioned this issue Nov 20, 2015
Merged
gpbl added a commit that referenced this issue Nov 20, 2015
@gpbl
Add a test case for #95
250b642
@gpbl gpbl added the bug label Nov 20, 2015
@gpbl gpbl closed this as completed in #96 Nov 20, 2015
@gpbl
Copy link
Owner

gpbl commented Nov 20, 2015

Published as v1.1.5 🤖

@jkillian
Copy link
Contributor Author

@gpbl think you forgot to run the build for bower 😉

@gpbl
Copy link
Owner

gpbl commented Nov 20, 2015

Grrr yes sure... I have to remember to run the prerelease task each time... because that boring prepublish thing in npm :(

Anyway, I would not publish a new npm release for this. I just updated dist and tagged 1.1.6 – bower should catch it, right?

@jkillian
Copy link
Contributor Author

Yep, that should work - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpbl @jkillian