Fix bug where endpoint months could not be shown #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpbl
added a commit
that referenced
this pull request
Nov 20, 2015
Fix bug where endpoint months could not be shown
|
Thanks, i've added a test case for it! |
|
Great! I think we may have added redundant test cases though - the tests I had in my PR are very similar to the tests you added. (No big deal, just wanted to let you know in case) |
|
Oh sorry sorry! I didn't see it 🎣 |
gpbl
added a commit
that referenced
this pull request
Nov 21, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95