feat: mocks upload files in tests #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
force-pushed
the
132-mocks-upload-files-in-tests
branch
from
da4df39 to
7a10781
Compare
LinaYahya
approved these changes
Aug 26, 2024
pyphilia
reviewed
Aug 27, 2024
ReidyT
force-pushed
the
132-mocks-upload-files-in-tests
branch
from
97c425e to
b130b65
Compare
pyphilia
approved these changes
Aug 28, 2024
ReidyT
force-pushed
the
132-mocks-upload-files-in-tests
branch
2 times, most recently
from
9156108 to
7e864fc
Compare
ReidyT
force-pushed
the
132-mocks-upload-files-in-tests
branch
2 times, most recently
from
450036d to
3998222
Compare
- feat(test): setup uploaded image before the test Co-Authored-By: ReidyT <thibault.reidy@hotmail.ch>
ReidyT
force-pushed
the
132-mocks-upload-files-in-tests
branch
from
3998222 to
d808725
Compare
|
There is an issue in the builder view where we have to click twice on the "Add the labels" step. I created a separated issue for that, because it was not introduced in this PR. #167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upload the image before the tests.
This PR propose a solution to the PR #136. The apps-query-client from graasp/graasp-apps-query-client# should be used, because MSW is mocking the upload and download of app settings files.