Migrates to msw 2 #389
Merged
Migrates to msw 2 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReidyT
force-pushed
the
migrate-to-msw-2
branch
2 times, most recently
from
2eb5bf3 to
508dfdf
Compare
ReidyT
force-pushed
the
migrate-to-msw-2
branch
from
508dfdf to
cb29863
Compare
pyphilia
reviewed
Aug 29, 2024
* feat: mocks upload app settings files Co-Authored-By: ReidyT <thibault.reidy@hotmail.ch>
ReidyT
force-pushed
the
migrate-to-msw-2
branch
from
24464e3 to
990dcc6
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates MSW to v2, but also includes the mocks of the upload app settings files as well as download app settings file (GET /download-app-setting-url/:id). This PR allows to mock the upload and download file for name-the-frame app.
If you are more interested on the mock files, check these handlers:
${apiHost}/${buildUploadAppSettingFilesRoute(':id')}${buildAppSettingDownloadUrl(':appSettingId')}