Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clipboard messages #110

Merged
merged 2 commits into from
Feb 24, 2023
Merged

feat: add clipboard messages #110

merged 2 commits into from
Feb 24, 2023

Conversation

spaenleh
Copy link
Member

closes #109

@spaenleh spaenleh linked an issue Feb 22, 2023 that may be closed by this pull request
Add builder copy to clipboard translations #109
Closed
@spaenleh spaenleh self-assigned this Feb 22, 2023
@spaenleh spaenleh added the feature New feature or request label Feb 22, 2023
@spaenleh spaenleh mentioned this pull request Feb 22, 2023
Merged
1 task
codeofmochi
codeofmochi approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think, I've left a small nitpick regarding translation semantics

src/langs/fr/messages.json Show resolved Hide resolved
@spaenleh
Copy link
Member Author

Thank you @dialexo, I changed the semantics in english to express the fact that it was not possible to copy to the clipboard.

@spaenleh spaenleh requested a review from codeofmochi February 24, 2023 09:36
@spaenleh spaenleh merged commit b0f9140 into main Feb 24, 2023
@github-actions github-actions bot mentioned this pull request Feb 24, 2023
Merged
@spaenleh spaenleh deleted the 109-add-builder-copy-to-clipboard-translations branch February 24, 2023 09:46
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add builder copy to clipboard translations
2 participants
@spaenleh @codeofmochi