93/mui5 #127
Closed
93/mui5 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyphilia
requested changes
May 30, 2022
package.json
Outdated
Comment on lines
69
to
70
| "react": "18.1.0", | ||
| "react-dom": "18.1.0" |
There was a problem hiding this comment.
Last time I've tried it was not possible to use react 18 with uppy (which is used to upload files). Is it still possible to use graasp-ui if we stay on react17? Or maybe we should tag the current version of ui and not update for compose.
There was a problem hiding this comment.
It seems they fixed the problem see this pull-request in uppy repo with uppy@2.10.0.
There was a problem hiding this comment.
I just tried, the issue is from react side, they do not support cjs, which is used by uppy. The fix looks pretty easy so I hope it will be merged soon.
# Conflicts: # .eslintrc # package.json # src/ItemFlag/FlagItemButton.tsx # src/Loader/Loader.tsx # src/Main/Main.tsx # src/itemLogin/ItemLoginAuthorization.test.tsx # src/itemLogin/ItemLoginAuthorization.tsx # src/items/FileItem.tsx # src/items/LinkItem.tsx # src/items/S3FileItem.tsx # src/types.ts # yarn.lock
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards moving graasp-ui to muiv5.
For the moment, all
makeStylescalls have been substituted for the@mui/stylesalternative. In the future, using theemotionalternative withstyledandsxprops. Should also make sure that everything works as expected in compose.closes #93