93 new mui5 #163
Merged
93 new mui5 #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@juancarlosfarah Done! |
juancarlosfarah
requested changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased branch of #127
All components have been migrated to mui5.
This branch Includes new added components and their stories (storybook).
All components do not have tests, but it can be incremental.
Maybe it's interesting to setup visual testing? https://storybook.js.org/docs/react/writing-tests/visual-testing The free tier allows 5000 free screenshots which might be enough.
I've setup the accessibility plugin but didn't tune all components given the feedback.
close #93