Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show empty JSON icon when value is null #5944

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Conversation

hannahblair
Copy link
Collaborator

Description

We previously showed the Empty state even if we weren't actually rendering the JSON node.

Now, if the value is undefined or an empty string, the JSON component will not render.
If the JSON value is null, the Empty state will show. (Previously, if it was null, it would show the text "null").

Kapture 2023-10-17 at 11 38 38

Closes: #5845

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 17, 2023

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
Visual tests all good! Build review
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/a0bd3974ae94aa52f52487fdcf2e6f9dacca2f01/gradio-3.48.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@a0bd3974ae94aa52f52487fdcf2e6f9dacca2f01#subdirectory=client/python"

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 17, 2023

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
@gradio/json patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Show empty JSON icon when value is null

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

pngwn
pngwn previously approved these changes Oct 17, 2023
Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for taking care of this @hannahblair!

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @hannahblair!

@hannahblair hannahblair merged commit 465f589 into main Oct 17, 2023
13 checks passed
@hannahblair hannahblair deleted the fix-empty-JSON-value branch October 17, 2023 13:11
This was referenced Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weird empty style of gr.JSON when used with the Blocks API
3 participants