Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show empty JSON icon when value is null #5944

Merged
merged 9 commits into from
Oct 17, 2023
Merged

Show empty JSON icon when value is null #5944

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c4386da
show empty json icon when value is null
hannahblair Oct 17, 2023
b5b5050
add changeset
gradio-pr-bot Oct 17, 2023
031af9f
Merge branch 'main' into fix-empty-JSON-value
hannahblair Oct 17, 2023
871bad1
move empty check logic to parent component
hannahblair Oct 17, 2023
397727f
add changeset
gradio-pr-bot Oct 17, 2023
b2756c3
revert changes
hannahblair Oct 17, 2023
e0bbc3c
add changeset
gradio-pr-bot Oct 17, 2023
e0599fb
tweak
hannahblair Oct 17, 2023
acf7be9
add changeset
gradio-pr-bot Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/twenty-dryers-wave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@gradio/json": patch
"gradio": patch
---

fix:Show empty JSON icon when `value` is `null`
6 changes: 0 additions & 6 deletions js/json/static/JSON.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
<script lang="ts">
import { onDestroy } from "svelte";
import { fade } from "svelte/transition";
import { JSON as JSONIcon } from "@gradio/icons";
import { Empty } from "@gradio/atoms";
import JSONNode from "./JSONNode.svelte";
import { Copy, Check } from "@gradio/icons";

Expand Down Expand Up @@ -58,10 +56,6 @@
<div class="json-holder">
<JSONNode {value} depth={0} />
</div>
{:else}
<Empty>
<JSONIcon />
</Empty>
{/if}

<style>
Expand Down
9 changes: 8 additions & 1 deletion js/json/static/JSONNode.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<script lang="ts">
import { JSON as JSONIcon } from "@gradio/icons";
import { Empty } from "@gradio/atoms";

export let value: any;
export let depth: number;
export let collapsed = depth > 4;
Expand Down Expand Up @@ -57,7 +60,11 @@
&#125;
{/if}
{:else if value === null}
<div class="json-item null">null</div>
<div class="json-item null">
<Empty>
<JSONIcon />
</Empty>
</div>
{:else if typeof value === "string"}
<div class="json-item string">
"{value}"
Expand Down
Loading