Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom component fixes #9711

Merged
merged 11 commits into from
Oct 16, 2024
Merged

Custom component fixes #9711

merged 11 commits into from
Oct 16, 2024

Conversation

freddyaboulton
Copy link
Collaborator

@freddyaboulton freddyaboulton commented Oct 15, 2024

Description

@gradio/markdown is not a dependency of @gradio/atoms so dev/build was broken for components that used them.

The sanitize-html library cannot be imported in the browser I think (uses require and has no export named default). I tried messing with optimizeDeps in the component config but it didn't work. So just changing the code in MarkdownCode to defer the import.

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Tests

  1. PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests: bash scripts/run_all_tests.sh

  2. You may need to run the linters: bash scripts/format_backend.sh and bash scripts/format_frontend.sh

@freddyaboulton freddyaboulton added the v: patch A change that requires a patch release label Oct 15, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 15, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website building...
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/2dac2730ed12621b16d76f43872f775c909c2eca/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@2dac2730ed12621b16d76f43872f775c909c2eca#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/2dac2730ed12621b16d76f43872f775c909c2eca/gradio-client-1.6.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/2dac2730ed12621b16d76f43872f775c909c2eca/dist/lite.js""></script>

@freddyaboulton freddyaboulton added the t: fix A change that implements a fix label Oct 15, 2024
@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 15, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
@gradio/markdown patch
@gradio/sanitize patch
@self/build patch
gradio patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Custom component fixes

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@freddyaboulton
Copy link
Collaborator Author

Not sure why npm-previews is failing but js-test is unrelated.

You can test the markdown sanitize change like this

import gradio as gr

gr.Interface(lambda x: f"Hello {x}", gr.Textbox(label="Name", info="**YOUR** name"), "textbox")

Copy link
Collaborator Author

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pairing on this @pngwn 🐐

Copy link
Member

@pngwn pngwn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks @freddyaboulton!

@freddyaboulton
Copy link
Collaborator Author

Thank you @pngwn !!

@freddyaboulton freddyaboulton merged commit 7134fc2 into main Oct 16, 2024
19 of 23 checks passed
@freddyaboulton freddyaboulton deleted the custom-component-fixes branch October 16, 2024 22:11
@aliabd aliabd mentioned this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: fix A change that implements a fix v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants