Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website build issue #9756

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Fix website build issue #9756

merged 6 commits into from
Oct 18, 2024

Conversation

aliabd
Copy link
Collaborator

@aliabd aliabd commented Oct 18, 2024

Website build action is currently failing because of a dependency loop introduced in #9711 where atoms -> markdown -> atoms

I undid the change and removed markdown from atoms, but obviously it was added for a reason so we need to figure out how to fix the right way.

Just need to check if this works first

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 18, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/53265dba2c7d5297393eea3b14ba2321559c0623/gradio-5.1.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@53265dba2c7d5297393eea3b14ba2321559c0623#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/53265dba2c7d5297393eea3b14ba2321559c0623/gradio-client-1.7.0.tgz

Use Lite from this PR

<script type="module" src="https://gradio-lite-previews.s3.amazonaws.com/53265dba2c7d5297393eea3b14ba2321559c0623/dist/lite.js""></script>

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Oct 18, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms minor
@gradio/chatbot minor
@gradio/dataframe minor
@gradio/markdown minor
@gradio/markdown-code minor
@self/build minor
gradio minor
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Fix website build issue

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

Copy link
Collaborator

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the right approach! Thanks @pngwn @aliabd !

@aliabd aliabd merged commit 92f337c into main Oct 18, 2024
20 of 24 checks passed
@aliabd aliabd deleted the website-build-fix branch October 18, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants