Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grafana Agent Flow doesn't support Prometheus exemplars #2420

Closed
rfratto opened this issue Oct 24, 2022 · 2 comments · Fixed by #2574
Closed

Grafana Agent Flow doesn't support Prometheus exemplars #2420

rfratto opened this issue Oct 24, 2022 · 2 comments · Fixed by #2574
Assignees
@rfratto
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Milestone
v0.30.0

Comments

@rfratto
Copy link
Member

rfratto commented Oct 24, 2022

Grafana Agent Flow currently doesn't support Prometheus exemplars.

It looks like prometheus.remote_write will properly send exemplars if they were written to the WAL, but the current FlowMetric abstraction means that no exemplars get written to the WAL.

See #2037 for one proposal which can fix this issue.
@aknuds1
Copy link

aknuds1 commented Oct 24, 2022

This is a regression, right? From which Agent version?

@rfratto
Copy link
Member Author

rfratto commented Oct 24, 2022

This is specific to Grafana Agent Flow, which was introduced in v0.28.0 and only enabled when EXPERIMENTAL_ENABLE_FLOW=1 is set in environment variables. The workaround is to not use Flow.

@rfratto rfratto added this to the v0.30.0 milestone Nov 3, 2022
@rfratto rfratto moved this from Todo to In Progress in Grafana Agent (Public) Nov 30, 2022
@rfratto rfratto self-assigned this Nov 30, 2022
Repository owner moved this from In Progress to Done in Grafana Agent (Public) Nov 30, 2022
@rfratto rfratto reopened this Nov 30, 2022
Repository owner moved this from Done to In Progress in Grafana Agent (Public) Nov 30, 2022
@rfratto rfratto mentioned this issue Nov 30, 2022
Merged
rfratto added a commit to rfratto/agent that referenced this issue Nov 30, 2022
@rfratto
component/prometheus: support exemplars in Prometheus component pipel…
c8ac14d 
…ines

This commit allows exemplars to be passed around in Prometheus component
pipelines. To support this change, the prometheus.Interceptor struct was
extended to support intercepting any call to the Appendable interface.

Support for metadata is also added, though that code path is currently
not invoked in our usage of the Prometheus scraper.

Fixes grafana#2420.
rfratto added a commit that referenced this issue Nov 30, 2022
@rfratto
Support exemplars in Prometheus component pipelines (#2574)
03b9598 
This commit allows exemplars to be passed around in Prometheus component
pipelines. To support this change, the prometheus.Interceptor struct was
extended to support intercepting any call to the Appendable interface.

Support for metadata is also added, though that code path is currently
not invoked in our usage of the Prometheus scraper.

Fixes #2420.
Repository owner moved this from In Progress to Done in Grafana Agent (Public) Nov 30, 2022
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rfratto rfratto

Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Grafana Agent (Public)
Status: Done
Milestone
v0.30.0
Development

Successfully merging a pull request may close this issue.

Support exemplars in Prometheus component pipelines rfratto/agent
2 participants
@aknuds1 @rfratto