Support exemplars in Prometheus component pipelines #2574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ines This commit allows exemplars to be passed around in Prometheus component pipelines. To support this change, the prometheus.Interceptor struct was extended to support intercepting any call to the Appendable interface. Support for metadata is also added, though that code path is currently not invoked in our usage of the Prometheus scraper. Fixes grafana#2420.
rfratto
force-pushed
the
flow-exemplar-support
branch
from
262b26c to
c8ac14d
Compare
mattdurham
reviewed
Nov 30, 2022
github-actions
bot
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows exemplars to be passed around in Prometheus component pipelines. To support this change, the prometheus.Interceptor struct was extended to support intercepting any call to the Appendable interface.
Support for metadata is also added, though that code path is currently not invoked in our usage of the Prometheus scraper.
Fixes #2420.