-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consume leading dots when converting from carbon #296
Conversation
apparently graphite allows an arbitrary amount. I tested upto 6: echo '......dietertest7' 123 $(date +%s) | nc localhost 2003 results in a series called dietertest7. tested with current latest graphite.
graphite allows them, but our backends should be more strict see grafana/metrictank#811
route/schemas.go
Outdated
} | ||
elements[0] = elements[0][1:] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like there is more to the story. see grafana/metrictank#1008 |
Closing in favor of #375 |
That PR doesn't seem to do enough or what this PR is about. Remember that most of this project is about ingesting, manipulating and emitting carbon streams |
I'll re-open this until I update M20 to use |
|
I'm doing some housekeeping in this repo, I'll close this PR as it seems stale. Feel free to reopen if you still think this is worth it. |
No description provided.