Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consume leading dots when converting from carbon #296

Closed
wants to merge 3 commits into from

Conversation

Dieterbe
Copy link
Contributor

No description provided.

apparently graphite allows an arbitrary amount.

I tested upto 6:

echo '......dietertest7' 123 $(date +%s) | nc localhost 2003

results in a series called dietertest7.
tested with current latest graphite.
graphite allows them, but our backends should be more strict

see grafana/metrictank#811
@Dieterbe Dieterbe requested a review from DanCech August 21, 2018 15:22
route/schemas.go Outdated
}
elements[0] = elements[0][1:]
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dieterbe
Copy link
Contributor Author

looks like there is more to the story. see grafana/metrictank#1008
this will need a bit more work pending further investigation.

@robert-milan
Copy link
Contributor

Closing in favor of #375

@Dieterbe
Copy link
Contributor Author

That PR doesn't seem to do enough or what this PR is about. Remember that most of this project is about ingesting, manipulating and emitting carbon streams
Schema lib is only used for select output plugins such as grafanaNet output

@robert-milan
Copy link
Contributor

I'll re-open this until I update M20 to use EatDots and ensure it is enforced in the ingest path here.

@robert-milan robert-milan reopened this Aug 19, 2019
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@npazosmendez
Copy link
Contributor

I'm doing some housekeeping in this repo, I'll close this PR as it seems stale. Feel free to reopen if you still think this is worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants