add function to eat dots #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replay
reviewed
Jul 17, 2019
|
Looks good to me. It's mine so I can't approve it. Also in case anyone was interested I did initially try it with regexp just to see how the performance was, and it was terrible. |
fkaleo
approved these changes
Jul 18, 2019
Dieterbe
reviewed
Jul 18, 2019
Co-Authored-By: Dieter Plaetinck <dieter@grafana.com>
This was referenced Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a function which eats all multiple consecutive dots and removes leading and trailing dots. This does NOT implement usage of the function. That should be done in separate pull requests in the respective repositories where it is required.
See also: https://github.com/raintank/tsdb-gw/issues/64 grafana/metrictank#1008 grafana/metrictank#811 grafana/carbon-relay-ng#296