feat(Timeseries): Add total resource consumption in legend #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit test coverage
|
|
My only comment would be, I find the incosistency weird with the single value labels (again #95)
|
I understand, it's a temporary state to provide a different view that I demoed to @bryanhuhta yesterday. Also, adding the total for each timeseries makes things unreadable in some cases: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s):
-Whenever the UI displays a single timeseries, the total resource consumption is displayed in the legend:
This PR also does some refactorings to prepare the integration of the Comparison view.
📖 Summary of the changes
See diff tab for specific comments
🧪 How to test?
-