refactor(SceneByVariableRepeaterGrid): Pull out "groupBy" logic out of the class #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egend for single series
Unit test coverage
|
grafakus
commented
Aug 1, 2024
| @@ -36,15 +36,18 @@ interface SceneByVariableRepeaterGridState extends EmbeddedSceneState { | |||
| variableName: string; | |||
| items: GridItemData[]; | |||
| headerActions: (item: GridItemData, items: GridItemData[]) => VizPanelState['headerActions']; | |||
| mapOptionToItem: ( | |||
There was a problem hiding this comment.
Decoupling: this new option allows the consumers of the class to customize how they build the grid items data.
grafakus
commented
Aug 1, 2024
| value: option.value as string, | ||
| label: option.label, | ||
| queryRunnerParams: { | ||
| serviceName: option.value as string, |
There was a problem hiding this comment.
Way cleaner/more explicit than before
grafakus
commented
Aug 1, 2024
| @@ -30,6 +30,18 @@ export class SceneExploreFavorites extends SceneObjectBase<SceneExploreFavorites | |||
| body: new SceneByVariableRepeaterGrid({ | |||
| key: 'favorites-grid', | |||
| variableName: 'favorite', | |||
| mapOptionToItem: (option) => { | |||
| // see FavoritesDataSource.ts | |||
| const { index, value, panelType, queryRunnerParams } = JSON.parse(option.value as string); | |||
… objects instead of setting state
simonswine
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Description
Related issue(s): is blocked by #108
This PR aims at making
SceneByVariableRepeaterGridmore generic.We achieve this:
SceneLabelValuesGridclass, responsible for rendering the panels grid after the user has selected a "groupBy" valueWe have a bit of duplicated code, but it's temporary. In the next PR, we'll start customizing
SceneLabelValuesGridso that the "Comparison" flow is easier to understand for the user (currently it's not obvious for users to understand how they can compare 2 label values).📖 Summary of the changes
See diff tab for specific comments
🧪 How to test?