Add configuration to opt out of removal of default reviewers #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdbaldry
force-pushed
the
jdb/2024-09-optional-removal-of-default-reviewers
branch
2 times, most recently
from
9455f75 to
d3c48bc
Compare
It requires extra permissions that can't be satisfied by the default `GITHUB_TOKEN`. By making it configurable, teams can choose to use the default token and sacrifice this feature, or use a GitHub App if they want it. Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
force-pushed
the
jdb/2024-09-optional-removal-of-default-reviewers
branch
from
d3c48bc to
1532965
Compare
baldm0mma
approved these changes
Sep 23, 2024
I'm getting different output locally... Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry
deleted the
jdb/2024-09-optional-removal-of-default-reviewers
branch
jdbaldry
added a commit
to jdbaldry/pyroscope
that referenced
this pull request
Sep 23, 2024
aleks-p
pushed a commit
to grafana/pyroscope
that referenced
this pull request
Sep 24, 2024
jdbaldry
added a commit
to grafana/agent
that referenced
this pull request
Sep 27, 2024
Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked. The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message `Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."` Like in grafana/pyroscope#3557 (comment) Behavior was documented in grafana/grafana-github-actions#226 and made configurable in grafana/grafana-github-actions#227 `removeDefaultReviewers: false` instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It requires extra permissions that can't be satisfied by the default
GITHUB_TOKEN. By making it configurable, teams can choose to use the default token and sacrifice this feature, or use a GitHub App if they want it.