-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add release notes for v1.8 #3557
Conversation
Hello @korniltsev!
Please, if the current pull request addresses a bug fix, label it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Marc Sanmiquel <marcsanmiquel@gmail.com>
* docs: Add release notes for v1.8 * Update docs/sources/release-notes/v1-8.md Co-authored-by: Marc Sanmiquel <marcsanmiquel@gmail.com> --------- Co-authored-by: Marc Sanmiquel <marcsanmiquel@gmail.com> (cherry picked from commit 25b12bf)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3557-to-release/v1.8 origin/release/v1.8
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 25b12bf34acf45f26ba93a46745a39446f95da1a When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3557-to-release/v1.8
# Create the PR on GitHub
gh pr create --title '[release/v1.8] docs: Add release notes for v1.8' --body 'Backport 25b12bf34acf45f26ba93a46745a39446f95da1a from #3557' --label 'documentation' --label 'type/docs' --label 'backport' --base release/v1.8 --milestone release/v1.8 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3557-to-release/v1.8
# Create a pull request where the `base` branch is `release/v1.8` and the `compare`/`head` branch is `backport-3557-to-release/v1.8`.
# Remove the local backport branch
git switch main
git branch -D backport-3557-to-release/v1.8 |
* docs: Add release notes for v1.8 * Update docs/sources/release-notes/v1-8.md Co-authored-by: Marc Sanmiquel <marcsanmiquel@gmail.com> --------- Co-authored-by: Marc Sanmiquel <marcsanmiquel@gmail.com> (cherry picked from commit 25b12bf) Co-authored-by: Tolya Korniltsev <korniltsev.anatoly@gmail.com>
Use the default token injected into workflows since the GH_BOT_ACCESS_TOKEN is revoked. The default token doesn't have the permission used for unassigning default reviewers. If you don't have it, you get cryptic comments posted back on the PR after the backport PRs are opened with the message `Validation Failed: "Could not resolve to a node with the global id of '<NODE ID>."` Like in grafana/pyroscope#3557 (comment) Behavior was documented in grafana/grafana-github-actions#226 and made configurable in grafana/grafana-github-actions#227 `removeDefaultReviewers: false` instructs the workflow to not try to avoid the error but will of course not remove the default reviewers assigned on the backport PR.
No description provided.