Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Add build for arm64 #468

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Docker: Add build for arm64 #468

merged 2 commits into from
Oct 5, 2023

Conversation

michbeck100
Copy link
Contributor

Replacement for #397

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

AgnesToulet
AgnesToulet reviewed Oct 5, 2023
View reviewed changes
Copy link
Contributor

@AgnesToulet AgnesToulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! I left one small suggestion but apart from that, it looks good.

scripts/build_push_docker.sh Outdated Show resolved Hide resolved
@michbeck100 @AgnesToulet
adding suggestion from PR
27134ca 
Co-authored-by: Agnès Toulet <35176601+AgnesToulet@users.noreply.github.com>
@AgnesToulet AgnesToulet merged commit 2764e6b into grafana:master Oct 5, 2023
2 checks passed
@AgnesToulet AgnesToulet mentioned this pull request Oct 5, 2023
Closed
@michbeck100 michbeck100 deleted the feature/build-for-arm branch October 5, 2023 07:42
@michbeck100
Copy link
Contributor Author

Unfortunately the build failed. I will create another PR to fix this

@michbeck100 michbeck100 restored the feature/build-for-arm branch October 5, 2023 07:46
@michbeck100 michbeck100 deleted the feature/build-for-arm branch October 5, 2023 07:48
@AgnesToulet
Copy link
Contributor

This should fix it: #469

@AgnesToulet AgnesToulet mentioned this pull request Oct 16, 2023
Closed
@AgnesToulet AgnesToulet changed the title Build for arm64 Docker: Build for arm64 Oct 17, 2023
@AgnesToulet AgnesToulet changed the title Docker: Build for arm64 Docker: Add build for arm64 Oct 17, 2023
@AgnesToulet AgnesToulet mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgnesToulet AgnesToulet AgnesToulet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michbeck100 @CLAassistant @AgnesToulet