Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drone: Fix push to Docker step #469

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Drone: Fix push to Docker step #469

merged 2 commits into from
Oct 5, 2023

Conversation

AgnesToulet
Copy link
Contributor

Switch all scripts execution to be executed with /bin/bash instead of sh. This fixes the Drone current failure as the sh shell has no syntax to create arrays, but Bash has.

Copy link
Collaborator

@joanlopez joanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AgnesToulet AgnesToulet merged commit d284d5f into master Oct 5, 2023
4 checks passed
@AgnesToulet AgnesToulet deleted the fix-drone branch October 5, 2023 09:31
@michbeck100
Copy link
Contributor

Seems that the docker command doesn't support --platform: https://drone.grafana.net/grafana/grafana-image-renderer/197/1/10

Any ideas?

@michbeck100
Copy link
Contributor

michbeck100 commented Oct 5, 2023

This should fix it: #470

The image used to run the docker build was too old to include buildx. Tried running google/cloud-sdk locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants