Upgrade plugin dependencies to React 18 #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fridgepoet
force-pushed
the
205-upgrade-plugin-dependencies-to-react-18
branch
from
79cabe2
to
f30ffb5
Compare
idastambuk
force-pushed
the
205-upgrade-plugin-dependencies-to-react-18
branch
from
6cf2694
to
ec39537
Compare
* try using github_token * updating commands to match readme and also to kick the drone build
sarahzinger
approved these changes
Sep 11, 2023
| @@ -26,18 +26,18 @@ | |||
| "@babel/core": "^7.16.7", | |||
| "@emotion/css": "^11.1.3", | |||
| "@grafana/aws-sdk": "0.1.2", | |||
| "@grafana/data": "8.4.11", | |||
| "@grafana/e2e": "8.4.11", | |||
| "@grafana/data": "10.0.3", | |||
There was a problem hiding this comment.
Let's make sure we test this change with 9.4 for AMG, maybe we can reach out to folks at AWS to test on their end
| selectedEntityValue && selectedComponentValue | ||
| ? { | ||
| [DataBindingLabelKeys.entityId]: selectedEntityValue, |
There was a problem hiding this comment.
Just curious why were these changes necessary?
There was a problem hiding this comment.
This change is required due to the change in the definition for selectedDataBinding in iot-app-kit.
kevinwcyu
reviewed
Sep 11, 2023
package.json
Outdated
| @@ -118,6 +119,12 @@ | |||
| "debug": "^4.0.0", | |||
| "underscore": "^1.12.1", | |||
| "d3-color": "^3.1.0", | |||
| "log4js": "^6.4.0" | |||
| "log4js": "^6.4.0", | |||
| "react-dnd": "^16.0.1", | |||
There was a problem hiding this comment.
looks like react-dnd@16.0.1 is the version that iot-app-kit/* v7 uses so i don't think we need the resolution here.
sarahzinger
reviewed
Sep 19, 2023
CHANGELOG.md
Outdated
| @@ -1,8 +1,13 @@ | |||
| # Changelog | |||
|
|
|||
| ## 1.8.1 | |||
There was a problem hiding this comment.
Suggested change
| ## 1.8.1 | |
| ## 1.8.0 |
sarahzinger
reviewed
Sep 19, 2023
package.json
Outdated
| @@ -1,9 +1,9 @@ | |||
| { | |||
| "name": "grafana-iot-twinmaker-app", | |||
| "version": "1.7.1", | |||
| "version": "1.8.1", | |||
There was a problem hiding this comment.
Suggested change
| "version": "1.8.1", | |
| "version": "1.8.0", |
…/github.com/grafana/grafana-iot-twinmaker-app into 205-upgrade-plugin-dependencies-to-react-18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This upgrades plugin dependencies to React 18.
Which issue(s) this PR fixes:
Fixes #205
Special notes for your reviewer:
Context: https://raintank-corp.slack.com/archives/C01LVB0CYTW/p1692336771498409