Remove relative path info from executable field #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbrowne
added
type/bug
wbrowne
commented
Jun 13, 2024
|
Temporarily closing this as I need to address an issue first |
|
All good to go now 🚀 |
njvrzm
approved these changes
Jun 21, 2024
Co-authored-by: Will Browne <wbrowne@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently due to having UNIX style paths in the
executablefield, it is not possible for the datasource binary to be started on Windows.grafana/grafana-plugin-sdk-go#1007 allows us now to not require the nested datasource executable to live in the parent root directory.