Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #293

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Update dependencies #293

merged 5 commits into from
Jul 18, 2024

Conversation

kevinwcyu
Copy link
Contributor

What this PR does / why we need it:

Updates dependencies and fixes some simple deprecation warnings

Changes

  • Ran npx @grafana/create-plugin@latest update:
    • Automatically updated the files in the .config directory
    • Automatically created .cprc.json
  • .github/workflows/detect-breaking-changes.yml: remove reference to @grafana/e2e-selectors which is no longer used in TwinMaker
  • .nvmrc: bump node to the latest LTS version
  • README.md: add note to notify the TwinMaker team on changes to be released
  • cspell.config.json: added additional word to ignore for spellchecks
  • go.mod: bump github.com/grafana/grafana-plugin-sdk-go
  • jest-setup.js: automatic formatting changes
  • package.json:
    • scripts mostly automated changes from running npx @grafana/create-plugin@latest update
    • updated packages to the latest version, with the exception of some packages in dependencies as those are potentially bigger changes that might not be compatible with some versions of Amazon Managed Grafana
    • dependencies:
      • Moved some packages over from devDependencies
      • Updated @grafana/* packages to latest 10.x.x versions, but left existing aws related dependencies the same
    • devDependencies:
      • Removed @grafana/*, packages, react, react-dom that were added to dependencies by npx @grafana/create-plugin@latest update. This is to prevent having different versions of the same packages defined in both devDependencies and dependencies.
      • Removed packages that are already transitively required, e.g. there are some eslint plugins that are already installed with @grafana/eslint-config, there is no point having a separate version of those plugins installed.
    • resolutions:
      • Added "lodash.pick": "https://github.com/lodash/lodash/archive/refs/tags/4.17.21.tar.gz": the modularized packages for lodash are deprecated and don't receive updates for vulns
      • Add "react-use": "^17.5.0": to force it to a version without fast-loops
      • Removed "rxjs": "7.5.1": use the version of rxjs from @grafana/data
      • Removed "moment-timezone": "^0.5.35": yarn why moment-timezone shows 0.5.45 is the only version installed after removing the resolution
      • Removed "moment": "^2.29.4"``yarn why moment shows only versions without known vulns are installed after removing the resolution
      • Removed "@braintree/sanitize-url": "^6.0.1": yarn why @braintree/sanitize-url shows 7.0.0 is the only version installed after removing the resolution
      • Removed "yaml": "^2.2.2": yarn why yaml shows only versions without known vulns are installed after removing the resolution
      • Removed "prismjs": "^1.27.0": yarn why prismjs shows 1.29.0 is the only version installed after removing the resolution
      • Removed "minimatch": "^3.0.5": yarn why debug shows only versions without known vulns are installed after removing the resolution
      • Removed "xml2js": "^0.5.0": yarn why xml2js shows 0.5.0 is the only version installed after removing the resolution
      • Removed "debug": "^4.0.0": yarn why debug shows only versions without known vulns are installed after removing the resolution
      • Removed "underscore": "^1.12.1": this was previously required because of @grafana/e2e which is no longer used in
      • Removed "log4js": "^6.4.0": this was previously required because of @grafana/e2e which is no longer used in TwinMaker
      • Removed "@types/video.js": "^7.3.51": video.js is not imported in any of the source code so the types are not required
      • Removed "video.js": "8.3.0": 8.3.0 is already installed from @iot-app-kit/react-components
  • Fixed deprecation warnings:
    • DataQuery in @grafana/data deprecated in favor of DataQuery from @grafana/schema,
    • JSX.Element deprecated in favor of React.JSX.Element
    • toBeCalledTimes and toBeCalledWith deprecated in favor of toHaveBeenCalledTimes and toHaveBeenCalledWith
      • src/common/manager.ts
      • src/datasource/components/QueryOptions.tsx
      • src/datasource/requestLooper.ts
      • src/panels/scene-viewer/helpers.test.ts
      • src/panels/tests/sdkInit.spec.ts
      • src/panels/video-player/VideoPlayer.test.tsx

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I suggest view the diff with Hide whitespace enabled to hide formatting changes.

@kevinwcyu kevinwcyu requested a review from a team as a code owner July 16, 2024 20:08
Copy link
Collaborator

@hwandersman hwandersman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested datasource queries, the scene viewer panel, and video player panel on Grafana 9.4 and 10.4 locally. Everything looks good! Thank you for keeping dependencies up to date!

Copy link
Contributor

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@kevinwcyu kevinwcyu merged commit be9c655 into main Jul 18, 2024
4 checks passed
@kevinwcyu kevinwcyu deleted the kevinwcyu/update-deps branch July 18, 2024 13:56
@kevinwcyu kevinwcyu mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants