Streaming: Fix an issue with the time series panel and streaming data source when scrolling back from being out of view #31431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ource when scrolling back from being out of view
torkelo
requested review from
a team,
peterholmberg and
thisisobate
and removed request for
a team
torkelo
added
old backport v7.4.x
torkelo
requested review from
ryantxu
and removed request for
peterholmberg and
thisisobate
torkelo
commented
Feb 23, 2021
| @@ -135,7 +135,7 @@ export class PanelChrome extends Component<Props, State> { | |||
| // The next is outside a react synthetic event so setState is not batched | |||
| // So in this context we can only do a single call to setState | |||
| onDataUpdate(data: PanelData) { | |||
| if (!this.props.isInView) { | |||
| if (!this.props.isInView && data.state !== LoadingState.Streaming) { | |||
There was a problem hiding this comment.
wait this is not correct, need to always return, updating
ryantxu
approved these changes
Feb 23, 2021
|
This fixed the issue for me, without this fix there is a refresh when you scroll back |
bug report was for 7.4.2 (before graphng refactor), does this still affect master? (sry AFK) |
|
This bug affected all react panels . Had nothing to do with GraphNG |
achatterjee-grafana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31368