Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streaming: Fix an issue with the time series panel and streaming data source when scrolling back from being out of view #31431

Merged
merged 3 commits into from
Feb 24, 2021
Merged

Streaming: Fix an issue with the time series panel and streaming data source when scrolling back from being out of view #31431

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b5e3dc0
Streaming: Fixes an issue with time series panel and streaming data s…
torkelo Feb 23, 2021
527c434
Slight tweak
torkelo Feb 23, 2021
9239305
Merge remote-tracking branch 'origin/master' into streaming-and-chrom…
torkelo Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/app/features/dashboard/dashgrid/PanelChrome.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ export class PanelChrome extends Component<Props, State> {
// The next is outside a react synthetic event so setState is not batched
// So in this context we can only do a single call to setState
onDataUpdate(data: PanelData) {
if (!this.props.isInView) {
if (!this.props.isInView && data.state !== LoadingState.Streaming) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait this is not correct, need to always return, updating

// Ignore events when not visible.
// The call will be repeated when the panel comes into view
this.setState({ refreshWhenInView: true });
Expand Down