Add CODEOWNERS + add myself as maintainer #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a CODEOWNERS file as suggested in grafana/loki#2593 (comment).
There is also a new workflow, which contains a check so that we cannot forget to reflect changes in chart maintainers also in that file.
@maorfr @rtluckie @Xtigyro @zanhsieh I also added myself as maintainer. Hope that's ok if not then I am happy to remove it.
So far I have hardly reviewed PRs and only added comments as I felt not entitled to do so. In the end I just helped with the chart migration ;-)