Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS + add myself as maintainer #94

Merged
merged 1 commit into from
Nov 21, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# See https://github.com/scottrigby/prometheus-helm-charts/issues/12
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

# The repo admins team will be the default owners for everything in the repo.
# Unless a later match takes precedence, they will be requested for review when someone opens a pull request.
* @prometheus-community/helm-charts-admins

/charts/grafana/ @maorfr @rtluckie @torstenwalter @Xtigyro @zanhsieh
17 changes: 17 additions & 0 deletions .github/workflows/check-codeowners.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
name: Check CODEOWNERS

on: pull_request
jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: install yq
run: |
sudo snap install yq
- name: generate CODEOWNERS
run: |
./scripts/check-codeowners.sh > .github/CODEOWNERS
- name: check CODEOWNERS for modifications
run: |
git diff --exit-code
4 changes: 3 additions & 1 deletion charts/grafana/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: grafana
version: 6.1.7
version: 6.1.8
appVersion: 7.3.3
kubeVersion: "^1.8.0-0"
description: The leading tool for querying and visualizing time series and metrics.
Expand All @@ -17,5 +17,7 @@ maintainers:
email: maor.friedman@redhat.com
- name: Xtigyro
email: miroslav.hadzhiev@gmail.com
- name: torstenwalter
email: mail@torstenwalter.de
engine: gotpl
type: application
20 changes: 20 additions & 0 deletions scripts/check-codeowners.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/usr/bin/env bash

cat <<EOF
# See https://github.com/scottrigby/prometheus-helm-charts/issues/12
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
# https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

# The repo admins team will be the default owners for everything in the repo.
# Unless a later match takes precedence, they will be requested for review when someone opens a pull request.
* @prometheus-community/helm-charts-admins

EOF

for DIR in $(ls -1 -d ./charts/*)
do
FILE="$DIR/Chart.yaml"
DIR=$(echo $DIR | sed 's/^\.//')
MAINTAINERS=$(yq r $FILE 'maintainers.[*].name'| sed 's/^/@/' | sort --ignore-case)
echo $DIR/ $MAINTAINERS
done