refactor: rename recording verification to verification #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Llandy3d
commented
Sep 20, 2024
| @@ -11,7 +11,7 @@ export function applyRecordingVerificationRule( | |||
|
|
|||
| const verificationSnippet = ` | |||
| check(resp, { | |||
| 'Recording Verification Rule: status matches recording': (r) => r.status === ${response.statusCode}, | |||
| 'status matches ${response.statusCode}': (r) => r.status === ${response.statusCode}, | |||
There was a problem hiding this comment.
As per suggested we are going to have it differentiated by status code
cristianoventura
previously approved these changes
Sep 20, 2024
More than coming soon, it would be limited. Good suggestion I'm adding it since if you get rid of it you won't be able to add it back |
Llandy3d
dismissed stale reviews from e-fisher and cristianoventura
via
ea0fa23
going-confetti
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the
recording-verificationto justverification.It also adds an inline view for it and a message when trying to edit it.