Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop k6 run --out cloud test when it gets aborted from the web app #1880

Closed
na-- opened this issue Mar 4, 2021 · 1 comment · Fixed by #1965
Closed

Stop k6 run --out cloud test when it gets aborted from the web app #1880

na-- opened this issue Mar 4, 2021 · 1 comment · Fixed by #1965
Labels
cloud enhancement high prio
Milestone
v0.32.0

Comments

@na--
Copy link
Member

na-- commented Mar 4, 2021

This should be relatively easy now that #1869 is done. We might give outputs another optional interface, like WithThresholds and WithRunStatusUpdates, basically the missing TODO in the middle here 😅 https://github.com/loadimpact/k6/blob/a5d884155825b0b21406b5b25a508dc229830b49/output/types.go#L76-L90

Then the engine can pass every output that supports it (probably only the cloud for now) a reference to engine.Stop(): https://github.com/loadimpact/k6/blob/a5d884155825b0b21406b5b25a508dc229830b49/core/engine.go#L358-L363

This issue overrides #1160
@na-- na-- added enhancement cloud evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Mar 4, 2021
@na-- na-- added this to the v0.32.0 milestone Mar 4, 2021
@na-- na-- mentioned this issue Mar 4, 2021
Closed
@na-- na-- added high prio and removed evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Mar 23, 2021
@na--
Copy link
Member Author

na-- commented Apr 12, 2021

This should probably be an optional feature though, controlled with an environment variable and disabled by default. If someone is running a huge load tests locally, even if they generate too many metrics and the cloud stops accepting more, they may still want to see the summary at the end of the test.

@mstoykov mstoykov mentioned this issue Apr 14, 2021
Merged
3 tasks
mstoykov added a commit that referenced this issue Apr 14, 2021
@mstoykov
Make possible for the cloud output to stop the engine
6bc7af2 
This does add an interface that can be implemented by other outputs as
well.

fixes #1880
mstoykov added a commit that referenced this issue Apr 16, 2021
@mstoykov @na--
Make possible for the cloud output to stop the engine (#1965)
29075af 
This does add an interface that can be implemented by other outputs as
well.

fixes #1880

Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
Co-authored-by: na-- <n@andreev.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cloud enhancement high prio
Projects
None yet
Milestone
v0.32.0
Development

Successfully merging a pull request may close this issue.

Make possible for the cloud output to stop the engine grafana/k6
1 participant
@na--