-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make possible for the cloud output to stop the engine #1965
Conversation
I'll get back to you on the names later, but please make this a cloud output option, not a runtime option. |
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
==========================================
- Coverage 71.48% 71.43% -0.06%
==========================================
Files 183 183
Lines 14247 14257 +10
==========================================
Hits 10184 10184
- Misses 3432 3442 +10
Partials 631 631
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This does add an interface that can be implemented by other outputs as well. fixes #1880
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments.
Re: the name, StopRunWithError
sounds better to me than StopExecutionOnOutputSignal
, as "signal" has the Unix signal connotation. Though I would add Engine
to it since that's what happens, so StopEngineRunWithError
?
And I agree with the need for an integration test, but it could be done in a follow up PR.
Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
Co-authored-by: na-- <n@andreev.sh>
This does add an interface that can be implemented by other outputs as well.
fixes #1880
TODOs:
StopExecutionOnOutputSignal
as it makes it more accurate that we will over stop if the output couldn't be started, and that this is a signal from the output to stop not just that there was some error. Unfortunately, it's a bit of a mouthfulRelated to the last point, I decided to have an error be "returned" not just to call some function is so that we can always print it in some good known format instead of it being a responsibility of the output.