Helm: loki-canary test pod gets rendered even when tests are disabled

[elchenberg]

Describe the bug

I could not find out how to not deploy the loki-canary test pod using the Helm chart v6.4.3 when the loki-canary is enabled but the tests are disabled (test.enabled=false).

I think the issue was introduced with this change: 79b876b#diff-4f7364c8431077f51149aa596196fa56a856485769d10f6aa581c5728653015d

{{- with .Values.test }}
-{{- if and .enabled $.Values.monitoring.selfMonitoring.enabled $.Values.monitoring.lokiCanary.enabled }}
+{{- if $.Values.lokiCanary.enabled }}

I guess the change should have looked like this instead:

{{- with .Values.test }}
-{{- if and .enabled $.Values.monitoring.selfMonitoring.enabled $.Values.monitoring.lokiCanary.enabled }}
+{{- if and .enabled $.Values.lokiCanary.enabled }}

To Reproduce

Expected behavior

Test pods should not be created when tests are disabled.

Environment:

• Infrastructure: Kubernetes
• Deployment tool: helm

Screenshots, Promtail config, or terminal output

[elchenberg]

Correction: It is not getting deployed unless I run helm test. But it is getting rendered with helm template which is different to v5.47.2 of the Helm chart.

My values.yaml:

deploymentMode: SingleBinary
loki:
  commonConfig:
    replication_factor: 1
  storage:
    type: filesystem
  useTestSchema: true
singleBinary:
  replicas: 1
read:
  replicas: 0
backend:
  replicas: 0
write:
  replicas: 0
test:
  enabled: false

[ilbarone87]

I have same issue deploying Loki with ArgoCD

[ilbarone87]

@elchenberg i just end up setting lokiCanary.enabled: false

[elchenberg]

@ilbarone87 Unfortunately that does not work for me because I want to have the Loki Canary. 😕