Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[helm] test-canary template doesn't respect test.enabled flag #13124

Closed
aledefault opened this issue Jun 4, 2024 · 2 comments
Closed

[helm] test-canary template doesn't respect test.enabled flag #13124

aledefault opened this issue Jun 4, 2024 · 2 comments
Labels
area/helm component/loki-canary

Comments

@aledefault
Copy link

Describe the bug
test-canary template only checks if Loki Canary is enabled (lokiCanary.enabled). It should also checks test.enabled.

To Reproduce

  1. Install using Helm and using a value of test.enabled: false

To fix it

# test-canary.yaml
...
{{- if and .enabled $.Values.lokiCanary.enabled }}
...

Expected behavior
If test.enabled is false, loki-helm-test should not be deploy.

Environment:

  • Infrastructure: Kubernetes
  • Deployment tool: Helm
yincongcyincong added a commit to yincongcyincong/loki that referenced this issue Jun 8, 2024
@yincongcyincong
fix: grafana#13124
eecbde6
@yincongcyincong yincongcyincong mentioned this issue Jun 8, 2024
Closed
@lindhe
Copy link
Contributor

lindhe commented Dec 10, 2024

Seems like a duplicate of #12765?

@aledefault
Copy link
Author

aledefault commented Dec 15, 2024 •
edited
Loading

Seems like a duplicate of #12765?

Agree. Closed by your PR #15346. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm component/loki-canary
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #13124 test-canary template doesn't respect test.enabled flag yincongcyincong/loki
3 participants
@JStickler @lindhe @aledefault