Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support microsecond timestamp format #1407

Closed
wphan opened this issue Dec 12, 2019 · 4 comments · Fixed by #1426
Closed

Support microsecond timestamp format #1407

wphan opened this issue Dec 12, 2019 · 4 comments · Fixed by #1426
Assignees
@wphan
Labels
component/agent good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us!

Comments

@wphan
Copy link

wphan commented Dec 12, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
I'm currently using zerolog for my logging package and they can output microsecond timestamps.

Describe the solution you'd like
Add another parser for UnixUs here:

loki/pkg/logentry/stages/util.go

Line 81 in a2e2272

case "UnixNs":

Describe alternatives you've considered

  • adding three 0s to the end of my timestamps and treating them as UnixNs in promtail stage
  • Getting zerolog to support nanosecond timestamps 😄

Additional context
If there's interest on this I can work on the PR for this. Unless there is a better way to achieve this, any input is appreciated.
@cyriltovena
Copy link
Contributor

Yes I think this a good candidate for a PR, feel free to add another parser and document it.

@cyriltovena cyriltovena added component/agent good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! labels Dec 13, 2019
@yindia
Copy link
Contributor

yindia commented Dec 13, 2019

@cyriltovena Would like to work on this. ?

@pstibrany
Copy link
Member

@evalsocket feel free to send PR

wphan pushed a commit to wphan/loki that referenced this issue Dec 16, 2019
Support microsecond timestamp format
d82b163 
Adds microsecond timestamp support.

grafana#1407
@wphan wphan mentioned this issue Dec 16, 2019
Merged
@wphan
Copy link
Author

wphan commented Dec 16, 2019

#1426 can't seem to add reviewers

cyriltovena pushed a commit that referenced this issue Dec 19, 2019
@cyriltovena
Support microsecond timestamp format (#1426)
d627cda 
Adds microsecond timestamp support.

#1407
cyriltovena pushed a commit to cyriltovena/loki that referenced this issue Jun 11, 2021
@khaines
Merge pull request grafana#1407 from cortexproject/1342-cassandra-con…
c0c5f25 
…fig-yaml

Allow Cassandra config to be passed as YAML.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wphan wphan

Labels
component/agent good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support microsecond timestamp format wphan/loki
4 participants
@pstibrany @cyriltovena @wphan @yindia