Support microsecond timestamp format #1426
Conversation
Adds microsecond timestamp support. grafana#1407
|
|
| if err != nil { | ||
| return time.Time{}, err | ||
| } | ||
| return time.Unix(0, i*int64(time.Microsecond)), nil |
There was a problem hiding this comment.
I would just use *1000 instead. This has implicit requirement on durations being in nanosecond, while us -> ns is simple *1000 conversion.
There was a problem hiding this comment.
should the time.Millisecond for the UnixMs case be changed to *1000000 also then? I'm also a bit confused about the implicit requirement here, isn't the time package already based on the notion of durations being in nanosecond?
There was a problem hiding this comment.
should the
time.Millisecondfor theUnixMscase be changed to*1000000also then?
That would make sense.
I'm also a bit confused about the implicit requirement here, isn't the time package already based on the notion of durations being in nanosecond?
Yes it is, and that is the implicit part I'm talking about. Correct expression would be (time.Duration(i) * time.Microsecond).Nanoseconds(), which will work even if time.Duration starts to use seconds one day.
This is just a tiny nitpick. If you leave it as is, I'm fine with it.
Add GCS object client specific timeout
Which issue(s) this PR fixes:
Fixes #1407