feat: mixin / add loki compaction not successfull alert #14239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expr: ||| | ||
| # The "last successful run" metric is updated even if the compactor owns no tenants, | ||
| # so this alert correctly doesn't fire if compactor has nothing to do. | ||
| (time() - loki_compactor_apply_retention_last_successful_run_timestamp_seconds > 60 * 60 * 24) |
There was a problem hiding this comment.
Suggested change
| (time() - loki_compactor_apply_retention_last_successful_run_timestamp_seconds > 60 * 60 * 24) | |
| (time() - loki_boltdb_shipper_compact_tables_operation_last_successful_run_timestamp_seconds > 60 * 60 * 24) |
might be better to use the compaction metric instead of the last successful retention run.
metric name is misleading here, it refers to boltdb but it is updated for tsdb indexes as well.
There was a problem hiding this comment.
Thanks I might give metrics renaming a go if I have time
QuentinBisson
commented
Sep 26, 2024
QuentinBisson
force-pushed
the
feat-mixin-add-compaction-alert
branch
from
9b0cb43 to
a13601c
Compare
ashwanthgoli
reviewed
Oct 1, 2024
| time() - (loki_boltdb_shipper_compact_tables_operation_last_successful_run_timestamp_seconds{} > 0) | ||
| ) | ||
| by (%s, namespace) | ||
| > 60 * 60 * 24 |
There was a problem hiding this comment.
nit: might be worth using a shorter interval for both alerts like 3h? there would be query performance degradation if there are a lot of uncompacted indexes
There was a problem hiding this comment.
That makes sense yes :)
ashwanthgoli
approved these changes
Oct 2, 2024
|
Done :) |
|
I think the failing checks are unrelated to this PR :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We recently had issues with Loki's compactor as we found out it actually never once ran successfully so we added an alert and I thought it was a good idea to add it here as well.
This alert was inspired from https://github.com/grafana/mimir/blob/41a6c6d0521f7994a0c7e031c7f35bafd45aa75c/operations/mimir-mixin-compiled/alerts.yaml#L876
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR