-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mixin / add loki compaction not successfull alert #14239
Merged
ashwanthgoli
merged 10 commits into
grafana:main
from
QuentinBisson:feat-mixin-add-compaction-alert
Oct 2, 2024
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0c3784e
feat: mixin / add loki compaction not successfull alert
QuentinBisson 50d2d83
Merge branch 'main' into feat-mixin-add-compaction-alert
QuentinBisson f52a7ee
address review comments
QuentinBisson 8e4a892
Merge branch 'main' into feat-mixin-add-compaction-alert
QuentinBisson 48a456e
Fix alert to support multiple compactor pods running
QuentinBisson dd282cc
Merge branch 'main' into feat-mixin-add-compaction-alert
QuentinBisson a13601c
Fix alert to support multiple compactor pods running
QuentinBisson 80bb883
Change alert period from 24h to 3h
QuentinBisson b5081ff
Merge branch 'main' into feat-mixin-add-compaction-alert
QuentinBisson 64044aa
Merge branch 'main' into feat-mixin-add-compaction-alert
ashwanthgoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be better to use the compaction metric instead of the last successful retention run.
metric name is misleading here, it refers to boltdb but it is updated for tsdb indexes as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I might give metrics renaming a go if I have time