Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regexp filter: use modified package with optimisations #5542

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Mar 4, 2022

What this PR does / why we need it:

This is a repeat of #5315, which was reverted in #5413.

See https://github.com/grafana/regexp/tree/speedup#readme

Includes the following changes proposed upstream:

Checklist

  • NA Documentation added - not user-visible.
  • NA Tests updated - no functionality changes.
  • NA Add an entry in the CHANGELOG.md about the changes - there is already an entry for filters: use faster regexp package #5315.

See https://github.com/grafana/regexp/tree/speedup#readme

Includes the following changes proposed upstream:
* [regexp: allow patterns with no alternates to be one-pass](https://go-review.googlesource.com/c/go/+/353711)
* [regexp: speed up onepass prefix check](https://go-review.googlesource.com/c/go/+/354909)
* [regexp: handle prefix string with fold-case](https://go-review.googlesource.com/c/go/+/358756)
* [regexp: avoid copying each instruction executed](https://go-review.googlesource.com/c/go/+/355789)
* [regexp: allow prefix string anchored at beginning](https://go-review.googlesource.com/c/go/+/377294)
@bboreham bboreham requested a review from a team as a code owner March 4, 2022 12:31
@cyriltovena cyriltovena mentioned this pull request Mar 4, 2022
3 tasks
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 33c00ad into main Mar 4, 2022
@cyriltovena cyriltovena deleted the update-regexp-149c8afcd6cb branch March 4, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants