-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logfmt selective label extraction #6675
Conversation
c3d7b3b
to
0ab797d
Compare
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
/keepalive |
0ab797d
to
4907377
Compare
768c85f
to
8275502
Compare
db31124
to
1da5a9d
Compare
Oh my, so sorry to let this hit the stalebot 😬 We've talked about adding this for a long time!! Thanks so much for the PR, we've been super busy lately but will try to take a look at this as soon as we can!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question regarding the <label>_extracted
labels.
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
d2fbe29
to
1e4a1a2
Compare
./tools/diff_coverage.sh ../loki-main/test_results.txt test_results.txt ingester,distributor,querier,querier/queryrange,iter,storage,chunkenc,logql,loki Change in test coverage per package. Green indicates 0 or positive change, red indicates that test coverage for a package fell. + ingester 0%
+ distributor 0%
+ querier 0%
+ querier/queryrange 0%
+ iter 0%
+ storage 0%
+ chunkenc 0%
+ logql 0%
+ loki 0% |
/hold |
Benchmark test added.
|
5cd9990
to
b87b642
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are good to go! 🚢
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
b87b642
to
3ad1b9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Really nice work, apologies it took so long.
What this PR does / why we need it:
This PR introduces extracting labels from a log line in
logfmt
, with an extra option to rename them.For example, this query:
will extract the labels
msg
andstatus
from the following logfmt line:With the following results:
Another possible scenario with label renaming:
That produces the following results:
Which issue(s) this PR fixes:
Fixes #3355
Special notes for your reviewer:
Checklist
CHANGELOG.md
.docs/sources/upgrading/_index.md