Fail through to next middleware when querySizeLimit cannot be applied #9050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When the query size limiter can't limit the query, fail through to the next middleware instead of erroring. This can happen, for example, when a query spans schemas.
|
Hello @trevorwhitney!
Please, if the current pull request addresses a bug fix, label it with the |
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
trevorwhitney
changed the title
grafanabot
pushed a commit
that referenced
this pull request
Apr 5, 2023
…#9050) **What this PR does / why we need it**: When the query size limiter can't limit the query, fail through to the next middleware instead of erroring. This can happen, for example, when a query spans schemas, which is still a valid query case, so we want to make sure to fall back to existing behavior. --------- Co-authored-by: Owen Diehl <ow.diehl@gmail.com> (cherry picked from commit c587b53)
jeschkies
reviewed
Apr 12, 2023
| @@ -353,7 +353,8 @@ func (q *querySizeLimiter) Do(ctx context.Context, r queryrangebase.Request) (qu | |||
| // Only support TSDB | |||
| schemaCfg, err := q.getSchemaCfg(r) | |||
| if err != nil { | |||
| return nil, httpgrpc.Errorf(http.StatusInternalServerError, "Failed to get schema config: %s", err.Error()) | |||
| level.Error(log).Log("msg", "failed to get schema config, not applying querySizeLimit", "err", err) | |||
There was a problem hiding this comment.
I think this should be a warning level.
There was a problem hiding this comment.
addressed: #13029
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the query size limiter can't limit the query, fail through to the next middleware instead of erroring. This can happen, for example, when a query spans schemas, which is still a valid query case, so we want to make sure to fall back to existing behavior.