Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail through to next middleware when querySizeLimit cannot be applied #9050

Merged
merged 2 commits into from
Apr 5, 2023
Merged

Fail through to next middleware when querySizeLimit cannot be applied #9050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78938c2
Fail through to next middleware when cant limit
trevorwhitney Apr 5, 2023
ec0109b
Update pkg/querier/queryrange/limits.go
trevorwhitney Apr 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/querier/queryrange/limits.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,8 @@ func (q *querySizeLimiter) Do(ctx context.Context, r queryrangebase.Request) (qu
// Only support TSDB
schemaCfg, err := q.getSchemaCfg(r)
if err != nil {
return nil, httpgrpc.Errorf(http.StatusInternalServerError, "Failed to get schema config: %s", err.Error())
level.Error(log).Log("msg", "failed to get schema config, not applying querySizeLimit", "err", err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be a warning level.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed: #13029

return q.next.Do(ctx, r)
}
if schemaCfg.IndexType != config.TSDBType {
return q.next.Do(ctx, r)
Expand Down