operator: add mTLS authentication to tenants #9906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
requested changes
Jul 11, 2023
There was a problem hiding this comment.
Goes into the right direction. I left a couple of improvement comments to consider. However moving forward this PR needs to expand watching for Secret/ConfigMap changes on the lokistack controller level to reconcile the gateway tenants config (i.e. when mTLS certs are rotated).
JoaoBraveCoding
force-pushed
the
log-4289
branch
from
11cc45e
to
d5e294d
Compare
periklis
reviewed
Jul 13, 2023
periklis
reviewed
Jul 13, 2023
operator/internal/manifests/internal/gateway/gateway-tenants.yaml
Outdated
Show resolved
Hide resolved
periklis
requested changes
Jul 14, 2023
operator/internal/handlers/internal/gateway/tenant_secrets_test.go
Outdated
Show resolved
Hide resolved
periklis
approved these changes
Jul 18, 2023
JoaoBraveCoding
commented
Jul 18, 2023
7 tasks
periklis
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
https://issues.redhat.com/browse/LOG-4289
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/upgrading/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR