operator: Fix OIDC.IssuerCAPath by updating it to type CASpec #9972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some hardish edges still to polish will finish them once #9906 gets merged |
7 tasks
JoaoBraveCoding
force-pushed
the
fix-issuerCAPath
branch
from
209e5af
to
78a1f14
Compare
JoaoBraveCoding
changed the title
periklis
approved these changes
Jul 21, 2023
LinTechSo
pushed a commit
to LinTechSo/loki
that referenced
this pull request
Jul 21, 2023
…a#9972) Co-authored-by: Periklis Tsirakidis <periklis@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently OIDC.IssuerCAPath only accepts a string without actually mounting any volume on the gateway deployment
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: Depends on #9906
Checklist
CONTRIBUTING.mdguide (required)CHANGELOG.mdupdatedadd-to-release-noteslabeldocs/sources/upgrading/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PR