This repository was archived by the owner on Aug 23, 2023. It is now read-only.
Retention ready timestamp #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dieterbe
force-pushed
the
retention-ready-timestamp
branch
from
1578fbf to
226aebe
Compare
Dieterbe
force-pushed
the
retention-ready-timestamp
branch
from
226aebe to
8567fed
Compare
Dieterbe
force-pushed
the
retention-ready-timestamp
branch
from
8567fed to
4585ff7
Compare
woodsaj
reviewed
Dec 13, 2018
| retention.Ready, err = strconv.ParseBool(parts[4]) | ||
| if err != nil { | ||
| return nil, err | ||
| // 0 (default) is effectively the same as 'true' |
There was a problem hiding this comment.
Need to clarify that the ready field used to be true|false. Otherwise, this comment won't make any sense when read in 6months time.
woodsaj
reviewed
Dec 13, 2018
docs/config.md
Outdated
| # so you rather query other archives, even if they don't have the retention to serve your queries | ||
| # ready: whether, or as of what data timestamp, the archive is ready for querying. | ||
| # This is useful if you recently introduced a new archive, but it's still being populated, so doesn't have the data metrictank might otherwise think there is | ||
| # It supports to syntaxes: |
woodsaj
approved these changes
Dec 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow retention 'ready' to be a unix timestamp.
this helps in situations where an archive for example has TTL of 2 months, but only 1 month worth of data.
previously we could only control whether the archive was used (for all of the 2 months window) or not.
now we can control to only use it for requests that need data more recent than 1 month.