This repository was archived by the owner on Aug 23, 2023. It is now read-only.
improve performance of hashing seriesbytag with fnv #1436
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the poor performance of
BySeriesWithTagsFnv
. It moves the code fromfnv
into the method itself which reduces our allocations to 1 and speeds things up quite a bit.It also adds the tests back into
schema
, and creates a new test specifically for the old and new methods used to obtain the partition withfnv
in this PR.These benchmarks were not performed in a suitable environment for benchmarking, but I think the difference is large enough to not warrant it.
Benchcmp
Original
New