Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

support bySeriesWithTagsFnv, move str->method logic to schema #1444

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

Dieterbe
Copy link
Contributor

@Dieterbe Dieterbe commented Aug 27, 2019

we forgot to include support for bySeriesWithTagsFnv. the functionality was in the schema package, but not yet a way to use it.

@Dieterbe Dieterbe requested a review from robert-milan August 27, 2019 06:18
@Dieterbe
Copy link
Contributor Author

Dieterbe commented Aug 27, 2019

note to self: once approved, do the same for tsdb-gw, crng

@robert-milan
Copy link
Contributor

we forgot to include support for bySeriesWithTagsFnv. the functionality was in the schema package, but not yet a way to use it.

We were just waiting until we could merge the performance improvements from #1436.

Copy link
Contributor

@robert-milan robert-milan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one comment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants