Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify direct and caching RuleStores in ruler #9434

Merged
merged 1 commit into from
Oct 4, 2024

Commits on Oct 3, 2024

  1. Unify direct and caching RuleStores in ruler

    Instead of using two different `RuleStore` implementations within the Ruler,
    use a single caching implementation and selectively disable caching when
    required.
    
    This change removes the "direct" `RuleStore` implementation from the Ruler's
    gRPC and HTTP API layers. Instead, the caching implementation is used for all
    calls. In cases where caching returning stale results would not be acceptable,
    the caching is disabled _just_ for that call.
    
    This allows rule group contents to be safety cached with the understanding
    that it is safe to cache them because they will correctly invalidated when
    deleted or modified.
    
    Part of #9386
    
    Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
    56quarters committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d6abaff View commit details
    Browse the repository at this point in the history