use grafana/franz-go fork #9511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Ángel Ortuño <ortuman@gmail.com>
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <josue.abreu@gmail.com>
Merged
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <josue.abreu@gmail.com>
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <josue.abreu@gmail.com> (cherry picked from commit ab3e627)
gotjosh
added a commit
that referenced
this pull request
Oct 8, 2024
This reverts #9511 as it panics ingesters. The details are: ``` │ panic: runtime error: invalid memory address or nil pointer dereference │ │ panic: runtime error: invalid memory address or nil pointer dereference │ │ [signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x13b2350] │ $GOROOT/src/runtime/panic.go:785 +0x124 │ │ github.com/twmb/franz-go/pkg/kgo/internal/pool.(*BucketedPool[...]).Get(0x0?, 0x0?) ``` Signed-off-by: gotjosh <josue.abreu@gmail.com> (cherry picked from commit ab3e627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Replacing current
franz-godependency with our own fork, based onv1.17.1, which includes the following changes:*kgo.Recordpooling support franz-go#1Which issue(s) this PR fixes or relates to
Fixes n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.