Ingester circuit breaker deactivate() function #9743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr00se
changed the title
pr00se
changed the title
deactivate() function
pr00se
changed the title
deactivate() function
| cb.active.Store(true) | ||
| }) | ||
| } | ||
|
|
||
| func (cb *circuitBreaker) deactivate() { |
There was a problem hiding this comment.
So this PR basically adds a support to deactivate circuit breakers, but it doesn't actually deactivate them anywhere?
There was a problem hiding this comment.
Correct -- I wanted to keep the changes small, so will add the invocation in another PR. The plan is to call it from https://github.com/grafana/mimir/blob/main/pkg/ingester/downscale.go when we change the read-only state.
4 tasks
pr00se
added a commit
that referenced
this pull request
Oct 28, 2024
* Log request type in circuit breaker state change messages * Test blocking reads if push circuit breaker is open * Add circuit breaker deactivate() * Don't set active state twice when initial delay is 0 * Log when breakers are activated/deactivated * Only log when actually changing circuit breaker state (cherry picked from commit 219f278) Co-authored-by: Patryk Prus <patryk@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Add a
deactivate()method to the ingester circuit breakers to allow them to be disabled and re-enabled dynamically.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.