Disable ingester push circuit breaker in read-only mode #9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr00se
added a commit
that referenced
this pull request
Oct 28, 2024
* Disable ingester push circuit breaker in read-only mode * Update CHANGELOG * Remove unused function (cherry picked from commit 2532be9)
pr00se
added a commit
that referenced
this pull request
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
We ran across an issue where the ingester's push circuit breaker was getting tripped when first starting, or when leaving read-only mode. The
--initial-delayoption allows us to add a delay before the circuit breaker starts measuring request times and making decisions. This is a solution for the cold start case, but does not help us when a running ingester is leaving read-only mode.This PR builds on #9743 to disable the ingester push circuit breaker when entering read-only mode, and enable it when leaving read-only mode. It also only enables the push breaker at start time if the ingester isn't starting in read-only mode. Now the same
--initial-delaysetting will apply when an ingester leaves read-only mode.Which issue(s) this PR fixes or relates to
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.